google-fonts-webpack-plugin icon indicating copy to clipboard operation
google-fonts-webpack-plugin copied to clipboard

Published 20 hours ago • verified publisher icon gabiseabra

cache fonts in build

Open jacobg opened this issue 6 years ago • 2 comments

Upstream failures can break the build: https://github.com/majodev/google-webfonts-helper/issues/81

Perhaps it would be a good idea to cache the fonts on the build machine, so such an issue doesn't break the build. And even when it's working, it would be more efficient to cache.

jacobg avatar Jun 27 '19 15:06 jacobg

I've made a cache feature in this PR : https://github.com/beyonk-adventures/google-fonts-webpack-plugin/pull/3

Also see https://github.com/gabiseabra/google-fonts-webpack-plugin/pull/22#issuecomment-654681729

subins2000 avatar Jul 07 '20 09:07 subins2000

Thanks @subins2000

The caching doesn't seem to take effect, because on either version 1.5.0 or 1.7.0 there is an upstream failure right now. It should be cached as I use it all the time.

40% building 58/89 modules 31 active /Users/j/workspace/f/console/node_modules/@fortawesome/pro-solid-svg-icons/index.es.js(node:14651) UnhandledPromiseRejectionWarning: Error: Service Unavailable

jacobg avatar Sep 17 '21 09:09 jacobg