Gabe De Luca

Results 60 comments of Gabe De Luca

Oh that's true we should accept the other pull requests before merging this. I'll update it when we start to push towards v2.

Done 😄 yes the `__proto__` error is gone 👍

@dougwilson should I make the changes, just like you made in [that](https://github.com/expressjs/morgan/commit/1533cdcc512f4daf20a93cb0ab3b18d6563a897f) commit to this repository also; the package.json & .travis.yml edits that force it to run checks using the...

done 👍 (three of the tests I had to add an `if (err) return done(err)`)

I rebased and squashed them. (without the commit you cherry-picked 👍 ) --- I'll continue to rebase as the master updates 👍 .

feel free to add the [needs rebase] tag back to this pr as needed.

@dougwilson there are some new errors/suggestions in the standardjs lint: ``` /home/travis/build/expressjs/session/index.js 284:15 error 'new Buffer()' was deprecated since v6. Use 'Buffer.alloc()' or 'Buffer.from()' (use 'https://www.npmjs.com/package/safe-buffer' for '

The `unnecessary escape character` seems possibly incorrect.

You might want to look at the replies to a similar pr (#128) as @dougwilson mentioned: > the memory store is just to get [the site] up and running

> The thing is express does come with a MemoryStore, and as much as you'd like people not to use it- they actually do. So why not just fix its...