fyne icon indicating copy to clipboard operation
fyne copied to clipboard

Add new theme updates

Open andydotxyz opened this issue 3 years ago • 6 comments

Previews and possible API considerations to be added here, this is a placeholder issue.

andydotxyz avatar Jun 06 '22 17:06 andydotxyz

The full design needs to be exported, but here are some details to show what is being worked on: Screenshot 2022-07-11 at 13 01 48 Screenshot 2022-07-11 at 13 02 03 Screenshot 2022-07-11 at 13 02 28 Screenshot 2022-07-11 at 13 02 37 Screenshot 2022-07-11 at 13 03 02 Screenshot 2022-07-11 at 13 03 18

andydotxyz avatar Jul 11 '22 12:07 andydotxyz

Will there be rounded corners? :eyes:

ErrorNoInternet avatar Jul 11 '22 14:07 ErrorNoInternet

For rounded corner, it might or might not happen in time for next release, but there is a PR #3121 which is showing good progress in adding the feature.

Bluebugs avatar Jul 11 '22 16:07 Bluebugs

well done , looks refreshing .

c1ngular avatar Jul 12 '22 01:07 c1ngular

good, i want change the button text size when mouse in and out,but i found the text style not export this field.

ddkwork avatar Jul 21 '22 01:07 ddkwork

i want change the button text size when mouse in and out,but i found the text style not export this field.

That is not supported by the standard button. To do this you would need to add your own button that altered size based on desktop events.

andydotxyz avatar Jul 23 '22 15:07 andydotxyz

Just adding it here that we discussed this during the last call. It seems like the text selection colour for dark theme is incorrect (too dark) and the section colour used in tree is still the old one for light theme. We need to check this through before closing as entirely done.

Jacalz avatar Nov 12 '22 20:11 Jacalz

An update on things that remain to be done (as far as I know):

  • [x] Update the selection colour for the light theme with new colour.
  • [x] Update the text selection colour in the dark theme to have better contrast.
  • [x] Make sure that the images in our README.md file are all updated (as well as those on the website of course).

Jacalz avatar Nov 15 '22 13:11 Jacalz

I just tested the latest version of fyne on the develop branch, and overall the new theme looks great.

One thing I don't like (and let me know if you'd rather have this conversation in a separate issue) is how light the border around unchecked checkboxes & radio buttons are now. They're basically invisible, which makes things less discoverable. Likewise disabled widgets are hard to see and read too, as they're so light now. It's fine with the dark theme, this mostly just affects the light one.

nickjwhite avatar Nov 22 '22 15:11 nickjwhite

I think this is complete. I get your point @nickjwhite but what we have done is to the design that was created. Would you be able to open a ticket to investigate the less discoverable input areas and we can look at it further?

andydotxyz avatar Nov 27 '22 21:11 andydotxyz