Faye Amacker
Faye Amacker
> Spent a little bit of time this afternoon investigating further, and came up with this commit: 7a8157a. With that applied, the build and all tests succeed on both amd64...
Thanks for reporting this. > I wouldn't exactly call this a bug, but it's also not quite a feature request. Yea, me too. It's not a bug because Go doesn't...
I have some new features planned for a future release (v2.5 or v2.6) that might be useful in resolving some or all of this issue. > How would you feel...
@yeli7289 Please feel free to reopen if you encounter this issue again.
Hey @yeli7289 @psilpa I'm unable to reproduce this problem and it works for me using: - System: MacOS 12.5.1 with M1 Pro - Installer: go1.18.5.darwin-arm64.pkg | Installer | macOS |...
@jwitko My current schedule is swamped, so I allowed the tests to run without review.
Hi @burdiyan Thanks for reporting this! :+1: I looked into it and have some ideas to try.
@zhangchiqing Instead of using bool flag to indicate v5, what do you think about using int flag for checkpoint version and set default to `MaxVersion` like this: https://github.com/onflow/flow-go/blob/124f1c581388b9da2783a391a0aa1d46ef505c16/ledger/complete/wal/checkpointer.go#L61
@zhangchiqing We also need to modify `RemoveCheckpoint` to remove all checkpoint files for v6, because v6 generates multiple files. https://github.com/onflow/flow-go/blob/124f1c581388b9da2783a391a0aa1d46ef505c16/ledger/complete/wal/checkpointer.go#L632-L634
@Kay-Zee This was paused because it sacrifices EN performance to gain memory (for both reads and updates). In August Spork, checkpoint v5 memory reductions (especially after PR 3050 got deployed...