fusion-core icon indicating copy to clipboard operation
fusion-core copied to clipboard

Deprecate old context properties and env vars

Open rtsao opened this issue 7 years ago • 1 comments

Future versions of fusion-cli, fusion-plugin-react-router, fusion-react, and fusion-plugin-i18n won't use these context properties anymore, so their existence may be misleading or cause confusion.

  • fusion-cli should provide the SSRBodyTemplate
  • Simulation tests should assert against ctx.rendered and ctx.template instead of ctx.body, because the final HTML depends on the SSRBodyTemplate which comes from fusion-cli and depends on build-time things.

rtsao avatar Sep 20 '18 18:09 rtsao

Codecov Report

Merging #299 into master will decrease coverage by 2.28%. The diff coverage is 78.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #299      +/-   ##
==========================================
- Coverage   91.91%   89.63%   -2.29%     
==========================================
  Files          18       18              
  Lines         408      434      +26     
  Branches       76       82       +6     
==========================================
+ Hits          375      389      +14     
- Misses         19       27       +8     
- Partials       14       18       +4
Impacted Files Coverage Δ
src/server-app.js 100% <ø> (ø) :arrow_up:
src/base-app.js 88.97% <ø> (-0.09%) :arrow_down:
src/get-env.js 100% <100%> (ø) :arrow_up:
src/plugins/ssr.js 80.26% <67.74%> (-11.93%) :arrow_down:
src/plugins/server-context.js 93.54% <92%> (-6.46%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 10934e4...981ba9a. Read the comment docs.

codecov[bot] avatar Sep 20 '18 18:09 codecov[bot]