portapack-havoc icon indicating copy to clipboard operation
portapack-havoc copied to clipboard

Audio App crashes Portapack

Open helmarw opened this issue 5 years ago • 32 comments

when switching from Audio app to e.g. TPMS and then back to Audio, Portapack crashes see short video I recorded, happens also from other apps but only when going back to Audio

IMG_5604.mp4.zip

i m using the version just downloaded and compiled 2-3 hours ago. the version I downloaded and compiled about three weeks ago (04-08 I think) did not have this issue as far as I know

helmarw avatar Apr 30 '20 13:04 helmarw

Can you test both versions and be sure that the older one works? If you tell me the timestamp of the one that works vs the one that does not I can check the differences.

BTW I compiled the "latest" -> https://github.com/eried/portapack-havoc/releases

eried avatar May 02 '20 11:05 eried

k, will let you know, luckily i saved the "old" one, alt least the binary. i will load it up and see if i can reproduce it there

helmarw avatar May 02 '20 14:05 helmarw

my mistake, havnt tested the older version very much (downloaded and compiled 8th April 2020). it has the same error. it only happens when Audio is in WFM-mode, switching to TPMS and than back to Audio. that crashes the whole thing second when i put audio in SPEC-mode and then change to TPMS i get a red screen (M4 GURU Meditation unhandled)... two short videos about that behaviour crashes.zip

other modes AM and NFM are not influenced either way. I didnt test any other apps, too many possible combination, it just happend that i was using exactly those two configurations for testing my TPMS sensors

helmarw avatar May 02 '20 15:05 helmarw

Strange I do not get a lock if I repeat exactly what you do in those videos, it might be a faulty portapack?

PS: btw! I noticed what a beautiful case, the mirrored engraved text worked flawlessly! 🤣🤣🤣

eried avatar May 03 '20 09:05 eried

i dont know what the Problem can be, that just how it is with my portapack

thnx, the housing is great, i printed it on a Formlabs Form2, work very well :)

helmarw avatar May 03 '20 20:05 helmarw

I can replicate this as well. If i go into the audio app, set it to WFM, exit and then go into ACARS or TPMS i get a had lock with a red screen reading "M4 Guru Medidtation Unhandled". I can also lock up the audio receiver, by going into WFM mode, exiting audio receiver, and then reopening it. The main screen then partially loads the and then hard locks. Seems to be something caused by WFM mode in the audio app. If i can provide anymore information, please let me know.

fcanaan avatar May 06 '20 16:05 fcanaan

I do not get the exact same type of lock up, but if I do audio, ACARS/TPMS and then back to audio, the audio app locks the portapack (only the upper part refreshes). Maybe some missing initialization stuff, I will play around it to see if I can find something

eried avatar May 06 '20 19:05 eried

Only with the audio app? I could check the initialization of that one but it would be helpful if you both @fcanaan @helmarw test all 👷‍♂️ the possible entering/exiting situations that work weird to pin point what is going on.

eried avatar May 06 '20 19:05 eried

Yes, i've only noticed it with the audio app, specifically in WFM mode. I can help you test whatever scenarios you need.

On Wed, May 6, 2020 at 12:54 PM Erwin Ried [email protected] wrote:

Only with the audio app? I could check the initialization of that one but it would be helpful if you both @fcanaan https://github.com/fcanaan @helmarw https://github.com/helmarw test all 👷‍♂️ the possible entering/exiting situations that work weird to pin point what is going on.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/furrtek/portapack-havoc/issues/350#issuecomment-624856341, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABC4P7XNVMFD7VURXPSECA3RQG6AHANCNFSM4MVSHR7Q .

--

FRANK CANAAN SYSTEMS ADMINISTRATOR

T: 805.265.6863 wearehathway.com http://wearehathway.com/

fcanaan avatar May 06 '20 20:05 fcanaan

Find the same problem in another app/in-out combination. Im no expert on the code, but with a few examples, it will be evident to fix 😂 I hope lol

eried avatar May 06 '20 20:05 eried

Strangely, the only error I can now replicate over and over is open audio, switch to wfm mode, exit audio, open audio again, crash. Top 1/3 of receiver menu shows the rest of the screen is black. Hard lock, have to reset.

IF I open another Listener app, close it,and then open audio again, it does not crash. Will keep testing.

On Wed, May 6, 2020, 1:15 PM Erwin Ried [email protected] wrote:

Find the same problem in another app/in-out combination. Im no expert on the code, but with a few examples, it will be evident to fix 😂 I hope lol

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/furrtek/portapack-havoc/issues/350#issuecomment-624866129, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABC4P7Q76MA3FBROPNCJR3DRQHAMLANCNFSM4MVSHR7Q .

fcanaan avatar May 06 '20 21:05 fcanaan

I’ve found a repeatable M4 Guru error. Turn unit on Select Receivers select pocsag wait 5 seconds then exit Select audio. change to spec mode. wait 5 seconds then exit select radiosonde M4 Guru Meditation Unhandled hard lock up.

fcanaan avatar May 07 '20 03:05 fcanaan

I can confirm tht M4 guru error, awesome! I will buzz around the code to see if I can find the source of the problem

eried avatar May 07 '20 10:05 eried

I think I found a way to make it stop hanging :) it needs a call to on_modulation_changed( in the constructor

@fcanaan have you found more bugs? I want to be sure I am not breaking something else before posting the fix

eried avatar May 08 '20 10:05 eried

@fcanaan @helmarw take a look and give me feedback of https://github.com/eried/portapack-havoc/releases/download/nightly/portapack-nightly_202005081310.bin It solves the 1/3 screen hang, but not the M4 guru error yet.

eried avatar May 08 '20 11:05 eried

For me, it is hanging if I go to capture, and then, after that into audio reciever

nemanjan00 avatar May 08 '20 11:05 nemanjan00

For me, it is hanging if I go to capture, and then, after that into audio reciever

OK you are right, this is a different kind of hang tho. We have 1/3 of screen, M4 guru meditation and "just frozen" now.

I think there is some stuff not cleanly terminated or such, because this https://github.com/furrtek/portapack-havoc/pull/353 is just calling the on_modulation_changed (which calls again the update_modulation ) and it fixes partially some issues. I am doing some test in pocsag and radiosonde constructors/destructors to see if I find the real issue.

eried avatar May 08 '20 11:05 eried

OK! so I found the M4 guru meditation problem, SPEC just leaves the sampling rate too high... so this issue would be 100% solved... "And I Would've Gotten Away With It Too. If It Weren't For You Meddling @nemanjan00 ." xDDDDD

eried avatar May 08 '20 12:05 eried

OK @nemanjan00 @fcanaan @helmarw

Try to hang: https://github.com/eried/portapack-havoc/releases/download/nightly/portapack-nightly_202005061640.bin somehow.

I think this ticket could be closed.

eried avatar May 08 '20 14:05 eried

@eried, I did not test that image, but, image built from your master does seem to work without any crashes for me.

nemanjan00 avatar May 08 '20 15:05 nemanjan00

I'll toss the image on my unit at lunchtime and report back to you.

On Fri, May 8, 2020, 8:35 AM Nemanja Nedeljković [email protected] wrote:

@eried https://github.com/eried, I did not test that image, but, image built from your master does seem to work without any crashes for me.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/furrtek/portapack-havoc/issues/350#issuecomment-625874059, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABC4P7W5Y4UXRFIBPNKLT43RQQRDRANCNFSM4MVSHR7Q .

fcanaan avatar May 08 '20 16:05 fcanaan

Loaded bin. Looking good. Haven't been able to crash it yet. Will keep trying. Thanks!

fcanaan avatar May 09 '20 02:05 fcanaan

No crashes in the image yet. I have found that the map does not load when you view a flight picked up by the ads-b app. The worldmap.bin has been generated correctly and is in the correct spot on the sd card. I even reverted to the last public image I had, and the map functionality came back. I went back to the image that doesnt have crashes, but no map.

fcanaan avatar May 14 '20 01:05 fcanaan

@fcanaan yes I changed the map file for a mercator one instead of equidistant, you can download my world_map.bin from sdcard.rar or check the pullrequests here to create yours from the updated jpg

eried avatar May 14 '20 06:05 eried

hi, sorry had to take care of other stuff last few weeks. great to see the development, I will try out the updated firmware soon!

helmarw avatar May 20 '20 07:05 helmarw

my mistake, havnt tested the older version very much (downloaded and compiled 8th April 2020). it has the same error. it only happens when Audio is in WFM-mode, switching to TPMS and than back to Audio. that crashes the whole thing second when i put audio in SPEC-mode and then change to TPMS i get a red screen (M4 GURU Meditation unhandled)... two short videos about that behaviour crashes.zip

other modes AM and NFM are not influenced either way. I didnt test any other apps, too many possible combination, it just happend that i was using exactly those two configurations for testing my TPMS sensors

GURU still there but Audio doesnt crash anymore, at least not that I could make it

helmarw avatar May 20 '20 08:05 helmarw

I cannot trigger guru anymore, how are you triggering it?

eried avatar May 20 '20 10:05 eried

im going into Audio and displaying SPEC and then exit Audio and start TPMS

helmarw avatar May 20 '20 14:05 helmarw

Nope, I fixed that :) it was merged today here or you can check my release bin too

eried avatar May 20 '20 19:05 eried

i recompiled it a aprox 11 hours ago from a fresh git clone or did you commit something afterwards?

helmarw avatar May 20 '20 19:05 helmarw