Marcelo Serpa
Marcelo Serpa
I folks 👋🏻 - I added an optional `width` prop, a `number` that gets interpolated as a string in the style and is assumed to use the `px` unit in...
> Apologies for being late to the party, but I'm not sure how I feel about a width prop. It would be more straightforward for consumers to control that with...
> Apologies for being late to the party, but I'm not sure how I feel about a width prop. It would be more straightforward for consumers to control that with...
> Have you had a chance to test the existing use cases? Thanks for pointing that out! I'll fix that and look at other usages.
I'm going to split this into two PRs: 1. I'll keep working on the width behavior changes in a separate PR. The main reason is that this PR already has...
> I'll keep working on the width behavior changes in a separate PR. See: https://github.com/WordPress/gutenberg/pull/61976.
It occurred to me that we should probably only merge this after we decide what to do with the default width/override behavior (https://github.com/WordPress/gutenberg/pull/61976). If so, both PRs should be merged...
There's a Playwright test [failing](https://github.com/WordPress/gutenberg/actions/runs/9290331396/job/25567476240?pr=61062), but it's [also failing](https://github.com/WordPress/gutenberg/actions/runs/9289883244/job/25564822251) on `trunk`, so not related to this changeset.
I forgot to paste the contributor text to the commit description; sorry! The PR had a lengthy list of discussions/messages and missed the [warning](https://github.com/WordPress/gutenberg/pull/61062#issuecomment-2123645210) at the top. Will take private...
@lena Thanks! What should we document in the deprecation comment as the alternative for this component?