El De-dog-lo

Results 485 comments of El De-dog-lo

could this replace the other one that didn't work instead?

@tansawit https://www.conventionalcommits.org/en/v1.0.0/

@tansawit you'll have to amend those commit messages to get it to pass (`git rebase -i develop`)

This could really help me out as I've been exploring how to use this functionality for https://github.com/ethpm/ethpm-rs So far I figured out this: ```rust #[derive(EthabiContract)] #[ethabi_contract_options(path = "MyContract.abi")] // Note:...

> Are we just adding it to brownie-mixes? It seems it would make sense to add to all of brownie no? General brownie support precedes support for these repos

Also noticed that this doesn't actually make slither fail the CI, so it's not really doing anything

> That will probably require to change the test from the yearn vault repo to use the pytest.approx + strategy.estimatedTotalAssets approach. Yes true!

https://github.com/iamdefinitelyahuman/eth-event/blob/80e2290810dfd856f9ab96d3df96e058fe8702aa/eth_event/main.py#L241-L278

I have no idea what context this was in, but I was probably working on setting up some sort of testing tool at the time. You can probably close this....