csstype

csstype copied to clipboard

I'm not exactly sure how much control you have over missing css properties, but I ran into a few that are sometimes needed when working with IE11 and CSS Grids. I believe the following are some of the missing CSS properties:

• -ms-grid-row
• -ms-grid-row-span
• -ms-grid-column
• -ms-grid-column-span

I can probably dig up some more references if that'd be helpful.

Found a couple more:

• -ms-grid-column-align
• -ms-grid-row-align

Using the follow definition file as a temporary workaround.

export type MSGridRowAlignProperty = 'start' | 'end' | 'center' | 'stretch';
export type MSGridColumnAlignProperty = 'start' | 'end' | 'center' | 'stretch';

declare module 'csstype' {
	interface Properties {
		msGridRow?: number;
		'-ms-grid-row'?: number;

		msGridRowSpan?: number;
		'-ms-grid-row-span'?: number;

		msGridRowAlign?: MSGridRowAlignProperty;
		'-ms-grid-row-align'?: MSGridRowAlignProperty;

		msGridColumn?: number;
		'-ms-grid-column'?: number;

		msGridColumnSpan?: number;
		'-ms-grid-column-span'?: number;

		msGridColumnAlign?: MSGridColumnAlignProperty;
		'-ms-grid-column-align'?: MSGridColumnAlignProperty;
	}
}

Thank you for raising this. My best guess would be to add them to mdn/data rather than mdn/browser-compat-data because it's an old spec. I created an issue to see what they have to say.

I've found that those properties were recently added to mdn/browser-compat-data, please @frenic would that be OK from your point of view?

Yes, I noticed. But these changes will be ignored as they were added as separate properties and no syntaxes are specified at https://github.com/mdn/data/ for these properties. An alternative could be to add them as patches.

I see, thanks for the clarification! Please could you elaborate on adding them as patches? I'll gladly prepare a PR with the changes, but I'd need to understand what you are suggesting :)

Related https://github.com/mdn/data/pull/425