freeCodeCamp icon indicating copy to clipboard operation
freeCodeCamp copied to clipboard

fix(curriculum): improve tests and instructions for Expense Tracker project

Open Dario-DC opened this issue 1 year ago • 5 comments

Checklist:

Closes #52722 Closes #53135 Closes #53463 Closes #52580

Dario-DC avatar May 02 '24 15:05 Dario-DC

I have reviewed the project. Provided that match/ case have not been introduced in the curriculum, I think this project can incorporate that in place if if..elif statements used to create the menu.

@ilenia-magoni, @fhsinchy, @Dario-DC What do you think?

This is the first time that elif is used. Personally, I'd keep the current code.

Dario-DC avatar May 08 '24 09:05 Dario-DC

Everything good, other than: I have doubts on the last step. We never introduce how to work with multiple fails, so it's kind of suddend and a bit of a whiplash to have if __name__. I would totally want to have it taught, but I would see it in a proper multifile project.

I'm okay with removing that step from this project. The password generator is the the first project in which we import something, and probably it makes sense to not use if __name__ == '__main__' before we explain how to import a module. In my opinion, if we decide to remove it, we should remove it from the case converter, too.

What do you think? @ilenia-magoni @zairahira @fhsinchy @larymak @ihechikara

Dario-DC avatar May 15 '24 18:05 Dario-DC

Everything good, other than: I have doubts on the last step. We never introduce how to work with multiple fails, so it's kind of suddend and a bit of a whiplash to have if __name__. I would totally want to have it taught, but I would see it in a proper multifile project.

I'm okay with removing that step from this project. The password generator is the the first project in which we import something, and probably it makes sense to not use if __name__ == '__main__' before we explain how to import a module. In my opinion, if we decide to remove it, we should remove it from the case converter, too.

What do you think? @ilenia-magoni @zairahira @fhsinchy @larymak @ihechikara

To maintain clarity and ensure a smooth learning curve, I'm in favor of removing the if __name__ == '__main__' step from both the password generator and case converter projects for now. So this will mean entirely getting rid of the respective steps and introducing a new approach right?

larymak avatar May 16 '24 05:05 larymak

To maintain clarity and ensure a smooth learning curve, I'm in favor of removing the if __name__ == '__main__' step from both the password generator and case converter projects for now. So this will mean entirely getting rid of the respective steps and introducing a new approach right?

My proposal is to remove it from the expense tracker and the case converter. And keep it in the password generator, since we talk about importing modules in that project.

If we remove it, we should simply delete the step in which we create if __name__ == '__main__' and keep the function call which is currently inside it.

Dario-DC avatar May 16 '24 08:05 Dario-DC

Thanks for your pull request.

Please remove the changes made to the non-English versions of the files. No need to close this pull request; just add more commits as needed.

We require you to change only English versions of files in the codebase. Translations to corresponding files in other world languages are managed on our translation platform. Once your pull request is merged, changes will be synced automatically to other world languages.

Please visit our contributing guidelines to learn more about translating freeCodeCamp's resources.

As always, we value all of your contributions.

Happy contributing!


Note: This message was automatically generated by a bot. If you feel this message is in error or would like help resolving it, feel free to reach us in our contributor chat.

camperbot avatar May 20 '24 08:05 camperbot

The improvements in the project overall are looking great 👍️

This is ready to be merged, but I think the sync needs to be run again:

image

zairahira avatar May 22 '24 10:05 zairahira

The title will be changed by crowdin I think, the sync script does the minimum to avoid errors

ilenia-magoni avatar May 22 '24 14:05 ilenia-magoni