foundation-sites icon indicating copy to clipboard operation
foundation-sites copied to clipboard

Menu link selectors should use the child combinator (.menu a vs .menu > li > a)

Open thomasfrobieter opened this issue 2 years ago • 0 comments
trafficstars

What should happen?

None Menu links inside a Foundation Menu component should not receive styles for menu links. Bad for megamenus, bad for buttons, no benefits? ...

What happens instead?

Well.. menu links inside a Foundation Menu component receive styles for menu links. ...

Possible Solution

.menu > li > a

instead

.menu a

Its very easy to apply menu padding to further links if required, while its sort of impossible to undo them. We used this fix for years now, no problems. This is the only reason we need to fork the whole repo :(

thomasfrobieter avatar Sep 14 '23 12:09 thomasfrobieter