foundation-sites icon indicating copy to clipboard operation
foundation-sites copied to clipboard

warning " > [email protected]" has incorrect peer dependency "motion-ui@latest".

Open maietta opened this issue 2 years ago • 3 comments

Not a big deal, just a warning. However, I feel I should drop a line here mentioning it. Seems only one "solution" exists on line to remove this and that's to move from node-sass to sass as the node-sass dependency is depreciated. That doesn't apply here.

warning " > [email protected]" has incorrect peer dependency "motion-ui@latest".

I've been told and I agree, that using the "latest" tag in dependencies are generally a bad idea and thus I think could be the reason for this warning. Not sure. It's hardcoded in the packages.json in this project repo.

Don't know if this should be hardcoded and resolve this warning, or left as-is as so far, nothing seems actually broken.

maietta avatar Feb 15 '23 17:02 maietta

This could easily be resolved by replacing the tag @latest by the actual required base dependency like the other ones. Anyone in the team willing to do that? If not I can submit a PR for this... but this seems overkill.

heyflo avatar Jul 26 '23 17:07 heyflo

This could easily be resolved by replacing the tag @latest by the actual required base dependency like the other ones. Anyone in the team willing to do that? If not I can submit a PR for this... but this seems overkill.

Thanks for pointing that out. Seems like such a simple fix but I'm actually not sure the correct way to implement this in my projects. Would love to see this fixed in the repo.

maietta avatar Jul 28 '23 02:07 maietta

Thanks for pointing that out. Seems like such a simple fix but I'm actually not sure the correct way to implement this in my projects. Would love to see this fixed in the repo.

"motion-ui": "2.0.4", will pin motion-ui at 2.0.4

I'm using zurb-foundation-template for a small site I built for someone and am just keeping it on 6.7.5:

"foundation-sites": "~6.7.5",

erutan avatar Sep 19 '23 16:09 erutan