foundation-sites icon indicating copy to clipboard operation
foundation-sites copied to clipboard

Published 20 hours ago • verified publisher icon foundation

fix: do not add aria-describedby to hidden inputs

Open ahukkanen opened this issue 3 years ago • 1 comments

Description

The abide component is currently potentially adding the aria-describedby attribute also on hidden inputs where it is not valid HTML.

The intention of the HTML validator is not to allow this through this rule: https://github.com/validator/validator/blob/b896708d94d12df67075c6cfd43afc0f8a140ef0/src/nu/validator/checker/schematronequiv/Assertions.java#L2042-L2045

However, currently it is buggy and the following HTML passes the HTML validator:

<!DOCTYPE html>
<html lang="">
<head>
  <title>Test</title>
</head>
<body>
  <form>
    <input type="hidden" name="test" value="abc" aria-describedby="test-abide-error">
    <span id="test-abide-error">Test</span>
  </form>
</body>
</html>

But this fix will fix it also in the future versions of the HTML validator when that bug is fixed.

Types of changes

  • [ ] Documentation
  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (anything that would change an existing functionality)
  • [ ] Maintenance (refactor, code cleaning, development tools...)

Checklist

  • [x] I have read and follow the CONTRIBUTING.md document.
  • [x] The pull request title and template are correctly filled.
  • [x] The pull request targets the right branch (develop or develop-v...).
  • [x] My commits are correctly titled and contain all relevant information.
  • [ ] I have updated the documentation accordingly to my changes (if relevant).
  • [x] I have added tests to cover my changes (if relevant).

ahukkanen avatar Nov 02 '22 14:11 ahukkanen