remix-hook-form icon indicating copy to clipboard operation
remix-hook-form copied to clipboard
verified publisher icon forge42dev

fixes bug with isValid & isSubmitted states

Open Centerworx opened this issue 2 years ago • 7 comments

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

If this is a new feature please add a description of what was added and why below:

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [x] Unit tests - Note, The test expected value was incorrect as with no errors {} isValid should be true.

Checklist:

  • [x] My code follows the guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings or errors
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] Any dependent changes have been merged and published in downstream modules

Centerworx avatar Oct 08 '23 16:10 Centerworx

@Centerworx I've seen that you've opened up 2 PR's which are almost identical, not sure which one to look at?

AlemTuzlak avatar Oct 10 '23 07:10 AlemTuzlak

Sorry about that, fixed.

Centerworx avatar Oct 10 '23 15:10 Centerworx

any updates on this?

flixoflax avatar Nov 12 '23 18:11 flixoflax

Waiting for feedback on my comments and will be good to merge

AlemTuzlak avatar Nov 12 '23 18:11 AlemTuzlak

Also, unfortunately remix run is not were I need it to be to work with my project. So I will not be working with it for the forceable future. Feel free to take over this change.

Centerworx avatar Nov 12 '23 21:11 Centerworx

@Centerworx Thank you so much for the work you put in and the feedback! I really do appreciate it even though my time is spread very thin and takes me a while to respond. I wish you the best of luck!

AlemTuzlak avatar Nov 13 '23 08:11 AlemTuzlak