eslint-plugin-aura icon indicating copy to clipboard operation
eslint-plugin-aura copied to clipboard

incorrect flagging ecma-intrinsics: updated whitelist.js

Open neha-naazneen opened this issue 1 year ago • 5 comments

The rule Validate-JavaScript-APIs(ecma-intrinsics) for JavaScript incorrectly flags couple of intrinsic methods, when they do appear to be part of the ecma specification(https://tc39.es/ecma262/). Upon scrutinizing I found that the whitelist.js used in the implementation(ecma-intrinsics.js) isn't updated. I've updated the whitelist.js.

neha-naazneen avatar Apr 25 '24 13:04 neha-naazneen

Thanks for the contribution! Before we can merge this, we need @neha-naazneen to sign the Salesforce Inc. Contributor License Agreement.

salesforce-cla[bot] avatar Apr 25 '24 13:04 salesforce-cla[bot]

Hi @Bartheleway, Thank you for your comment. Neha has added all the newly supported functions but testing for all of them is not done. We will review it and respond to your comment within this week.

Thanks, Sai Anurag

anurag-ar avatar May 14 '24 16:05 anurag-ar

Hello @Bartheleway, thank you for your feedback. I have compiled the code with Babel as requested and tested all the added functions to ensure they exhibit the expected behavior. All tests were successful, confirming that the functions work correctly within the Aura context.

Screenshot 2024-06-02 115359

neha-naazneen avatar May 31 '24 06:05 neha-naazneen

Hey @Bartheleway, I wanted to follow up on the pull request I submitted. I understand that maintainers are often busy, I wanted to check in to see if there's anything I can do to help move the review process along.

we are using this as a dependency, it would be greatly appreciated if these changes could be reviewed and merged at your earliest convenience.

neha-naazneen avatar Jul 11 '24 16:07 neha-naazneen

Hi @neha-naazneen, I'm not a maintainer of this project, just an umble user like you 😉 I hope Salesforce team will soon accept and merge this.

Bartheleway avatar Jul 11 '24 17:07 Bartheleway