dash-uploader icon indicating copy to clipboard operation
dash-uploader copied to clipboard

Published 20 hours ago • verified publisher icon fohrloop

Refactor / rewrite Upload_ReactComponent.react.js

Open fohrloop opened this issue 4 years ago • 8 comments

The Upload_ReactComponent.react.js would really need some refactoring. This would make further development a lot easier and the package more maintainable.

fohrloop avatar Jan 15 '21 22:01 fohrloop

I would like to help, but I have no idea where to start. Is there a description on how to setup the development environment?

sorenwacker avatar Jan 29 '21 03:01 sorenwacker

I'm very happy to hear! You can read the instructions for setting the development environment in the CONTRIBUTING.md. Please just let me know if you need any other guidance.

fohrloop avatar Jan 29 '21 04:01 fohrloop

Is this still being worked on? If not I would like to pick it up.

Vipulsh avatar Feb 25 '21 21:02 Vipulsh

I have not done anything for this but I don't know if @soerendip has. Great to hear @Vipulsh if you want to help!

fohrloop avatar Feb 26 '21 13:02 fohrloop

Alright, I will set up the dev environment first and then start working on it.

Vipulsh avatar Feb 27 '21 21:02 Vipulsh

I have created a pull request after making some changes.

Vipulsh avatar Mar 02 '21 18:03 Vipulsh

Great! Thank you @Vipulsh, I will have a look and do some testing once I have some time :)

fohrloop avatar Mar 04 '21 06:03 fohrloop

There has been some new merges (e.g. https://github.com/np-8/dash-uploader/pull/26), and the most up-to-date refactored branch is the v.0.5.0 release candidate: https://github.com/np-8/dash-uploader/tree/0.5.0

Some more refactoring could still be done. It might be useful to refactor with https://github.com/np-8/dash-uploader/issues/21.

fohrloop avatar Apr 01 '21 22:04 fohrloop