chef-user icon indicating copy to clipboard operation
chef-user copied to clipboard

Create .ssh directory when ssh_keypair is set #113

Open atikhono opened this issue 8 years ago • 3 comments

atikhono avatar Apr 10 '17 14:04 atikhono

@theckman Could you please have a look?

atikhono avatar Apr 11 '17 11:04 atikhono

@atikhono Happy to look. Do you have more information around what failure this resolves? What kind of resource call triggers it?

Our test kitchen tests haven't been failing, so it appears we are missing a test case there. Can you please enhance the test kitchen tests to fail if this were to regress?

Edit: Sorry for the edit. Along the lines of writing the tests, can you please enhance the commit message to detail what failure this is fixing? When someone runs git-blame in the future, it's helpful to know why changes were made to the source code. If you could squash the test addition, and additional commit details, in to one commit I'd really appreciate it!

theckman avatar Apr 11 '17 18:04 theckman

Ahem, okay so now I've had some caffeine and noticed #113. Sorry about that! That issue does show the head of the failure itself, which makes sense. I think a test case being written for this PR would solve my inquiry about what kind of resource call triggers it.

theckman avatar Apr 11 '17 18:04 theckman