flyteidl icon indicating copy to clipboard operation
flyteidl copied to clipboard

Published 20 hours ago • verified publisher icon flyteorg

Add datacatalog client

Open tnsetting opened this issue 4 years ago • 5 comments

This PR adds a datacatalog client in flyteidl which could be used by flyte propeller and flyteCTL. As discussed with @kumare3 previously we will not register the config section in this PR because of compatibility issue with current config file in propeller. When all users have added the config section we will register the config in other PR.

Type

  • [ ] Bug Fix
  • [x] Feature
  • [ ] Plugin

Are all requirements met?

  • [ ] Code completed
  • [ ] Smoke tested
  • [ ] Unit tests added
  • [ ] Code documentation added
  • [ ] Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/flyteorg/flyte/issues/839

Follow-up issue

NA OR https://github.com/lyft/flyte/issues/

tnsetting avatar Apr 07 '21 11:04 tnsetting

@kumare3 PTAL. Thanks

tnsetting avatar Apr 07 '21 13:04 tnsetting

lgtm!

kumare3 avatar Apr 07 '21 20:04 kumare3

@kumare3 Please take a look

tnsetting avatar May 06 '21 07:05 tnsetting

@kumare3 Could take another look for the PR?

tnsetting avatar Jun 08 '21 08:06 tnsetting

@EngHabu / @pmahindrakar-oss lets get the final review in and merge this change. Sorry for the delay @tnsetting

kumare3 avatar Jul 03 '21 23:07 kumare3