flyte icon indicating copy to clipboard operation
flyte copied to clipboard

Add listing to stow storage apis

Open bgedik opened this issue 1 year ago • 1 comments

Tracking issue

Part of RFC https://github.com/flyteorg/flyte/blob/b3add894fd879d6b6c11e37ba292ae04bf60afeb/rfc/system/5598-deterministic-errors-distributed-training.md#flytepropeller-backend

Why are the changes needed?

Deterministic error propagation, see: https://github.com/flyteorg/flyte/blob/b3add894fd879d6b6c11e37ba292ae04bf60afeb/rfc/system/5598-deterministic-errors-distributed-training.md#flytepropeller-backend

What changes were proposed in this pull request?

Adding listing APIs

How was this patch tested?

Unit tests

Setup process

Screenshots

Check all the applicable boxes

  • [ ] I updated the documentation accordingly.
  • [ ] All new and existing tests passed.
  • [X] All commits are signed-off.

Related PRs

https://github.com/flyteorg/flyte/pull/5616

Docs link

N/A

bgedik avatar Aug 20 '24 07:08 bgedik

Codecov Report

Attention: Patch coverage is 43.42105% with 43 lines in your changes missing coverage. Please review.

Project coverage is 36.22%. Comparing base (86c63f7) to head (16454bf). Report is 158 commits behind head on master.

Files with missing lines Patch % Lines
...ytestdlib/storage/mocks/composed_protobuf_store.go 0.00% 27 Missing :warning:
flytestdlib/storage/stow_store.go 67.74% 6 Missing and 4 partials :warning:
flyteadmin/pkg/common/mocks/storage.go 0.00% 2 Missing :warning:
flytepropeller/pkg/utils/failing_datastore.go 0.00% 2 Missing :warning:
flytestdlib/storage/mem_store.go 0.00% 2 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5674   +/-   ##
=======================================
  Coverage   36.21%   36.22%           
=======================================
  Files        1303     1303           
  Lines      109568   109644   +76     
=======================================
+ Hits        39683    39715   +32     
- Misses      65765    65805   +40     
- Partials     4120     4124    +4     
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 55.63% <0.00%> (-0.01%) :arrow_down:
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.21% <ø> (ø)
unittests-flyteidl 7.12% <ø> (ø)
unittests-flyteplugins 53.35% <ø> (ø)
unittests-flytepropeller 41.75% <0.00%> (-0.01%) :arrow_down:
unittests-flytestdlib 55.19% <45.83%> (-0.17%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 20 '24 17:08 codecov[bot]

If we support listing we can do map over directories

kumare3 avatar Sep 12 '24 04:09 kumare3

Messed up the DCO pretty bad, will create a new one

bgedik avatar Sep 12 '24 05:09 bgedik

https://github.com/flyteorg/flyte/pull/5741

bgedik avatar Sep 12 '24 05:09 bgedik