packages icon indicating copy to clipboard operation
packages copied to clipboard

[adaptive_scaffold] : 🐛 #141938 - Drawer stays open even on destination tap.

Open aliasgar4558 opened this issue 1 year ago • 1 comments

(#141938)

Changes included in PR are listed as follows

  • As per material guidelines, Drawer shall be dismissed when user taps any destination/item. If drawer is open, and user taps on any item, before calling onDestinationSelected() - we are now dismissing drawer.
  • CHANGELOG.md file updated.
  • Updated to v0.1.9.

Issue : https://github.com/flutter/flutter/issues/141938

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

aliasgar4558 avatar Mar 09 '24 05:03 aliasgar4558

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

flutter-dashboard[bot] avatar Mar 09 '24 05:03 flutter-dashboard[bot]

auto label is removed for flutter/packages/6289, due to - The status or check suite Linux repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit[bot] avatar Mar 21 '24 15:03 auto-submit[bot]

Looks like you'll need to update the CHANGELOG: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8752843542649031841/+/u/Run_package_tests/CHANGELOG_and_version_validation/stdout

gspencergoog avatar Mar 21 '24 15:03 gspencergoog

@gspencergoog Can I update NEXT with 0.1.8+1? Will that work?

aliasgar4558 avatar Mar 21 '24 16:03 aliasgar4558