packages

packages copied to clipboard

After 13.0.0 release of go_router package GoRouter.optionURLReflectsImperativeAPIs is not working correct. Isn't correct = url in browser doesn't updates after push, example you can see in new test, or in linked issue

List which issues are fixed by this PR. You must list at least one issue.

Pre-launch Checklist

• [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
• [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
• [x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
• [x] I signed the CLA.
• [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• [x] I linked to at least one issue that this PR fixes in the description above.
• [x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
• [x] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
• [x] I updated/added relevant documentation (doc comments with ///).
• [x] I added new tests to check the change I am making, or this PR is test-exempt.
• [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@chunhtai can you review this pull request?

@hangyujin Seems like @chunhtai is not online for the last 2 mouth. Can you review this Pull Request?

@polina-c mb you can help with review this PR? This is critical issue to me and i want to see this changes on pub.dev as soon as possible

@polina-c mb you can help with review this PR? This is critical issue to me and i want to see this changes on pub.dev as soon as possible

@hangyujin seems to be better person to review this

Hi, this PR looks good to me, thank you for fixing this issue introduced by 13.0.0.

@johnpryan Hi John, can you take a second look at this pr since chun-heng is on vacation? This pr fixes an issue that is introduced by go_router 13.0.0 because 13.0.0 refactored RouteMatchList to be a tree structure.

@anisovdev Can you bump the version to 13.2.2 and also update pubspec.yaml?

@hangyujin bumped

auto label is removed for flutter/packages/6236, due to This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

• Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@johnpryan Hi John, can you take a second look at this pr since chun-heng is on vacation? This pr fixes an issue that is introduced by go_router 13.0.0 because 13.0.0 refactored RouteMatchList to be a tree structure.

@johnpryan Review please this Pull Request

@hangyujin now this PR has two review