engine

engine copied to clipboard

As part of eliminating the Flutter buildroot (https://github.com/flutter/flutter/issues/67373), we are moving all third-party dependencies from //third_party to //flutter/third_party.

Oof, this is failing on:

Using prebuilt Dart SDK binary. If you are editing Dart sources and wish to compile the Dart SDK, set `--no-prebuilt-dart-sdk`.
Generating GN files in: out/host_debug_unopt
ERROR at //third_party/abseil-cpp/absl.gni:109:7: Can't load input file.
      "//third_party/googletest:gmock",
      ^-------------------------------
Unable to load:
  /b/s/w/ir/cache/builder/src/third_party/googletest/BUILD.gn
I also checked in the secondary tree for:
  /b/s/w/ir/cache/builder/src/flutter/build/secondary/third_party/googletest/BUILD.gn

How do I edit https://flutter.googlesource.com/third_party/abseil-cpp/+/refs/heads/main/absl.gni?

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

Converting to draft PR to keep it from coming up in triage.

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

@matanlurey this is pretty old should this be closed or are you planning on working on it? (Desktop triage)

I'll rebase this today. Thanks for the poke.