engine icon indicating copy to clipboard operation
engine copied to clipboard

Published 20 hours ago • verified publisher icon flutter

Backfilled unit tests for IncomingMessageDispatcher.

Open gaaclarke opened this issue 3 years ago • 1 comments

Pre-launch Checklist

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [x] I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • [ ] I listed at least one issue that this PR fixes in the description above.
  • [x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] I signed the CLA.
  • [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

gaaclarke avatar Aug 03 '22 21:08 gaaclarke

From PR triage: The new file needs to be added to the license golden file.

zanderso avatar Aug 04 '22 20:08 zanderso

Ping @cbracken

chinmaygarde avatar Aug 18 '22 20:08 chinmaygarde