buildroot icon indicating copy to clipboard operation
buildroot copied to clipboard

Migrate Dart dependency roller to new location of Dart SDK in checkout

Open whesse opened this issue 1 year ago • 1 comments

This change will need to be landed when moving the position of the Dart SDK source checkout from [buildroot]/third_party/dart to [flutter_engine]/third_party/dart in a Flutter engine source checkout. It cannot be landed before that point.

This script copies changed pinned dependencies from the Dart DEPS to the Flutter engine DEPS, when rolling a new version of Dart into engine.

Bug: https://github.com/flutter/flutter/issues/143335

  • [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • [x] I read the [Flutter Style Guide] recently, and have followed its advice.
  • [x] I signed the [CLA].
  • [x] I listed at least one issue that this PR fixes in the description above.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] I added new tests to check the change I am making, or this PR is [test-exempt].
  • [x] All existing and new tests are passing.

whesse avatar Mar 04 '24 14:03 whesse

Can this be changed to work with either the old or new path so it can be landed in advance of the migration?

jason-simmons avatar Mar 04 '24 15:03 jason-simmons

@whesse Are we fully prepared for the switch?

chinmaygarde avatar Mar 14 '24 20:03 chinmaygarde

The change is now compatible with both the old location and the new location. It is tested locally on flutter engine and monorepo checkouts, with both the src/third_party/dart location for the Dart SDK source checkout, and the new src/flutter/third_party/dart location for it.

So it can be reviewed now, and landed ahead of the move.

whesse avatar Mar 21 '24 12:03 whesse