Steven Guikal

Results 66 comments of Steven Guikal

I agree with @emersion that this PR should encompass *all* privileged protocols. As you mention, this is a temporary addition before a proper security model is added. The purpose of...

The resolution depends on what we want to apply this to. Currently, `format` and (maybe) `icon-path` can have trailing whitespace. At least for `format`, I don't think there's really any...

> I'm not sure of the effect on `icon-path`. Just thinking back on this, issues would only arise if your icon path had a space on the end, in which...

I'm thinking of trying to implement this so here's my thoughts on implementation: - Parse string normally with our own parser. - If a global setting (`format-date`) is true (so...

Ooh, this does seem nice and clean. I'm trying to think of a reason to split up the other format options (like ` `) but I can't think of anything...

No clue on whether this is the cause or not, but just want to mention that the TODO which ifreund pointed out in that thread is [still there](https://github.com/emersion/mako/blob/0e1a3637df6f85bdb931aa0aa27d645420803b77/wayland.c#L720-L722): https://github.com/emersion/mako/blob/0e1a3637df6f85bdb931aa0aa27d645420803b77/wayland.c#L720-L722

> What was the latest commit? By "Can you reproduce with the latest commit?" they just mean can you reproduce with the latest source code version as opposed to the...

If you're looking for an example yourself, [here you go](https://github.com/TheAvidDev/dotfiles/blob/master/mako/config). An example config would be nice though, I agree.

> To lower the maintenance cost, I guess that it should not be too difficult to generate the wiki page from the manual section with the minimal config example (I...

> How is app-name used? From `notify-send --help`: `-a, --app-name=APP_NAME Specifies the app name for the icon`. > Apologies for derailing the discussion, not sure where else to ask this....