Carlos Garcia

Results 132 comments of Carlos Garcia

I've done some tests and I found out that although the bullet point is vertically centered, in some cases it still looks like a bit displaced to the bottom. This...

> @fluiddot can this be merged and a new release made on https://github.com/wordpress-mobile/AztecEditor-iOS/releases? I think when that's ready, we can include this in the new Gutenberg Mobile release that is...

I've investigated the issue further and I found out that something similar happens in other apps. For example, I tested on the Slack app and it also happens that when...

I see that there's no reference to `acknowledgePurchase` method in the repo and looks like it's now mandatory for any non-consumable purchases. **This is very critical because if the purchase...

> Great work! This matcher would be quite useful. I left a few comments to consider. Thank you very much @dcalhoun for taking a look at this PR 🙇. Following...

Looks like most of the unit tests are failing with the following error: ``` TypeError: _interopRequireDefault is not a function ``` However, I managed to reproduce the same issue by...

> @fluiddot Do you have capacity to work on updating this PR? Hey @mdjastrzebski, my apologies for not being very active in the PR. I'd like to resume the work...

> @fluiddot would you be able to rebase the code and migrate it to typescript as the current codebase uses it now. @mdjastrzebski 😅 Sorry for the long delay on...

👋 I'd like to share that I'm working on adding the `toBeVisible` matcher in [this PR](https://github.com/testing-library/jest-native/pull/73) following a similar logic as the same `jest-dom` matcher ([reference](https://github.com/testing-library/jest-dom#tobevisible)). I think this matcher...

> 👋 I'd like to share that I'm working on adding the `toBeVisible` matcher in [this PR](https://github.com/testing-library/jest-native/pull/73) following a similar logic as the same `jest-dom` matcher ([reference](https://github.com/testing-library/jest-dom#tobevisible)). I think this...