flipperzero-firmware icon indicating copy to clipboard operation
flipperzero-firmware copied to clipboard

[FL-2674] Show error popup when NFC chip is not init/disconnected

Open Astrrra opened this issue 3 years ago • 4 comments

What's new

  • If rfalNfc state is not init (because the ST25R3916 chip is disconnected/broken), the NFC app will show an error popup and exit.

Verification

  • Verify that the NFC app works as usual
  • Disconnect the NFC board ribbon cable and verify that the NFC app shows an error screen

Checklist (For Reviewer)

  • [x] PR has description of feature/bug or link to Confluence/Jira task
  • [x] Description contains actions to verify feature/bugfix
  • [x] I've built this code, uploaded it to the device and verified feature/bugfix

Astrrra avatar Sep 08 '22 15:09 Astrrra

PVS-Studio report for commit a5b8e92e:

github-actions[bot] avatar Sep 08 '22 15:09 github-actions[bot]

Compiled firmware for commit a5b8e92e:

github-actions[bot] avatar Sep 08 '22 15:09 github-actions[bot]

@Astrrra we actually have dialog service to show standard errors

skotopes avatar Sep 08 '22 16:09 skotopes

@skotopes Right, didn't know about those, that's much better!

Astrrra avatar Sep 08 '22 17:09 Astrrra