Flipper-Android-App icon indicating copy to clipboard operation
Flipper-Android-App copied to clipboard

[ENHANCEMENT] Add application on F-Droid

Open RoiArthurB opened this issue 4 years ago • 12 comments

Hello,

In the scope of releasing the application in a full open-source environment, is it plan to release the app on the F-Droid alternative store ? https://f-droid.org/

RoiArthurB avatar Apr 23 '21 07:04 RoiArthurB

Look cool

LionZXY avatar May 03 '21 09:05 LionZXY

If you need some help, I think @IzzySoft can help you :)

RoiArthurB avatar May 03 '21 10:05 RoiArthurB

Quick hints:

  • establish Fastlane structures here in your repo (minimum: short_description.txt & full_description.txt for en-US; strongly recommended: also screenshots; recommended: also icon + featureGraphic; nice: also per-release changelogs and multiple languages)
  • optionally ask me to cross-check the structure
  • have a new tag with Fastlane inside
  • open a RFP (Request For Packaging) with F-Droid
  • we pick up from there :smiley:

With more details: F-Droid for advanced users and developers (shameless self-promotion of my article :see_no_evil:)

IzzySoft avatar May 03 '21 12:05 IzzySoft

I came here to suggest this! Would really like to see this feature or contribute if I can.

x-isopod-x avatar Nov 09 '21 14:11 x-isopod-x

Can I sign the f-droid APK with my signature? How?

LionZXY avatar Jun 17 '22 16:06 LionZXY

Not directly. But what you're probably looking for is a dual-signed APK (carrying yours and F-Droids signature). Look for reproducible builds.

IzzySoft avatar Jun 17 '22 20:06 IzzySoft

Any blockers that I can help with or things that need to still be completed?

BoBeR182 avatar Aug 17 '22 06:08 BoBeR182

Any blockers that I can help with or things that need to still be completed?

It just takes time. If anyone wants to do this, I'll help!

LionZXY avatar Aug 17 '22 10:08 LionZXY

I have opened a PR to start the metadata needed, you will still need to release this app with a new tag, and hopefully add changelog and other stuff like donation info and website to the RFP at FDroid.

BoBeR182 avatar Sep 01 '22 00:09 BoBeR182

Some issues where flagged here, https://gitlab.com/fdroid/rfp/-/issues/2187 mainly insecure Gradle configuration.

BoBeR182 avatar Sep 01 '22 06:09 BoBeR182

Can we reopen this until it's included?

BoBeR182 avatar Sep 01 '22 06:09 BoBeR182

https://gitlab.com/fdroid/fdroiddata/-/merge_requests/11685 for tracking and help.

BoBeR182 avatar Sep 05 '22 23:09 BoBeR182

How can we help get this through?

Flash1232 avatar Oct 22 '22 09:10 Flash1232

I guess it's up to @BoBeR182 currently to accept the suggested changes in the MR.

IzzySoft avatar Oct 22 '22 12:10 IzzySoft

Merged the changed and bumped the version to 1.2.2 (599) same one as on the Google Play store. Looks like there is still some errors with Gradle build process, see the following job for all the errors https://gitlab.com/BoBeR182/fdroiddata/-/jobs/3221672445

BoBeR182 avatar Oct 25 '22 06:10 BoBeR182

There are a lot of scanner errors in that log. Examples (bottom-up):

ERROR: Found Java JAR file at build-logic/plugins/convention/build/libs/convention.jar
ERROR: Found Java compiled class at build-logic/plugins/convention/build/classes/kotlin/main/com/flipperdevices/buildlogic/ApkConfig.class

I guess someone accidentally checked in build artifacts. In that case, I'd suggest to remove them again (ideally pruning, but for the build deleting would suffice). If those structures are there on purpose, the question is whether the F-Droid build would succeed if they were not there – in which case a scandelete or rm entry could be made in the build block, here for build-logic/plugins/convention/build. That would then avoid those errors, and the build would continue; it aborted due to the scanner ERRORs:

ERROR: Could not build app com.flipperdevices.app: Can't build due to 1128 errors while scanning

IzzySoft avatar Oct 25 '22 11:10 IzzySoft

@IzzySoft any ideas on this one, https://gitlab.com/BoBeR182/fdroiddata/-/jobs/3221854075 You last recommendation helped.

BoBeR182 avatar Oct 25 '22 15:10 BoBeR182

Yeah, looks much better already – and the build actually started :smiley:

Gradle build daemon disappeared unexpectedly (it may have been killed or may have crashed)

I'd say retry. If the error remains, being no Android dev I've no clue, sorry.

IzzySoft avatar Oct 25 '22 16:10 IzzySoft

It's very strange that it takes 40 minutes to assemble. Even on free githab runners, a clean project takes about 10 minutes to build.

Have you tried disabling the demon? What command is executed on the server? It now builds everything (even the wearos version). Can you tell it to only build the application (:instances:app:)?

I also think i should attach a link to GitHub Workflow: https://github.com/flipperdevices/Flipper-Android-App/blob/dev/.github/workflows/internal.yml#L54

LionZXY avatar Oct 26 '22 08:10 LionZXY

I would also like to say a big thanks to @BoBeR182 for doing this. And to other contributors

LionZXY avatar Oct 26 '22 08:10 LionZXY

Seems the compiled APK won't install on my phone, can you help debug? https://gitlab.com/fdroid/fdroiddata/uploads/2e1c4f5ae9c82e1a917a0bb38d66406e/com.flipperdevices.app_599.apk.gz https://gitlab.com/fdroid/fdroiddata/-/merge_requests/11685#note_1149898055

BoBeR182 avatar Oct 26 '22 21:10 BoBeR182

@BoBeR182 have you signed it? The CI spits out an unsigned APK.

IzzySoft avatar Oct 26 '22 22:10 IzzySoft

I assumed a rooted phone can just install unsigned APKs, I will learn how to self sign and try again.

BoBeR182 avatar Oct 26 '22 22:10 BoBeR182

I assumed a rooted phone can just install unsigned APKs

To my experience not. Most of my devices are rooted, and a simple adb install using an unsigned APK always failed (complaining of missing certs).

IzzySoft avatar Oct 27 '22 00:10 IzzySoft

Are reproducible builds possible? Or should we move ahead here? This is above my experience level. https://gitlab.com/fdroid/fdroiddata/-/merge_requests/11685#note_1171890546

BoBeR182 avatar Nov 16 '22 08:11 BoBeR182

Reproducible builds are not a requirement – while definitely something good to aim for. If it's above your experience, feel free to skip it for now and postpone it (especially if it would keep you from "going live" for an indefinite time). You can always add that later when you feel ready.

IzzySoft avatar Nov 16 '22 10:11 IzzySoft

https://gitlab.com/fdroid/fdroiddata/-/merge_requests/11685 is merged, I think we can close this, it should be showing up in the repos soon. There might be work needed to integrate updated changelogs, or other metadata.

BoBeR182 avatar Nov 20 '22 21:11 BoBeR182

Why is there no app icon in f-droid?

LionZXY avatar Nov 22 '22 11:11 LionZXY

There is no icon in the fastlane structure here (metadata/en-US/images/icon.png is missing). And the app is using XML icons only it seems (no PNG), so no PNG there to be used.

TL;DR: can easily be fixed by providing the icon.png in metadata :wink:

IzzySoft avatar Nov 22 '22 17:11 IzzySoft

Nice, the app is finally available on the F-Droid store (with the app icon for me) ! 🥳🥳

But the application crash when I try to open it for some reason... :/ @LionZXY Do you want to keep tracking that wrong build here or in another issue ? 🤔

RoiArthurB avatar Nov 23 '22 02:11 RoiArthurB