flathub icon indicating copy to clipboard operation
flathub copied to clipboard

Tracker for apps using old DConf access method

Open hadess opened this issue 6 years ago • 22 comments
trafficstars

This should be the full list of applications having access to GSettings in the host's DConf database by punching a hole in the sandbox.

Applications should instead rely on the xdg-desktop-portal "settings" portal, to get access to global or lockdown settings, and a keyfile GSettings backend.

If xdg-desktop-portal is new enough on the host (1.1.0 or newer), and the application's runtime includes GLib 2.60 (GNOME 3.32 or newer), then this should automatically work once dconf access is removed from the application's manifest.

Runtimes with host DConf access

Applications with host DConf access

hadess avatar Jun 14 '19 15:06 hadess

@hadess isn't flatpak 1.4 needed too?

Erick555 avatar Jun 14 '19 16:06 Erick555

@hadess isn't flatpak 1.4 needed too?

I don't think so, and my research doesn't show it would be needed either. Would be useful to say why you think this particular version is necessary.

hadess avatar Jun 14 '19 17:06 hadess

Because there is info about added dconf support in release notes: https://github.com/flatpak/flatpak/releases/tag/1.3.0 . Before I saw this ticket everyone was talking about flatpak 1.4 need.

https://github.com/flatpak/flatpak/commit/9e25dfabcd45dfd9d083887a52627c906bc81451

https://github.com/flatpak/flatpak/commit/4c5c359c91508585baa564047fc56c6eb4462b09

Erick555 avatar Jun 14 '19 18:06 Erick555

Because there is info about added dconf support in release notes: https://github.com/flatpak/flatpak/releases/tag/1.3.0 . Before I saw this ticket everyone was talking about flatpak 1.4 need.

It's useful but not strictly necessary.

hadess avatar Jun 15 '19 09:06 hadess

I think gradual adoption is fine as just jumping over now is a bad UX:

  • Without flatpak 1.4 suddenly users lose settings
  • Without xdg-desktop-portal 1.1 host integration will break on Wayland

Also fdo 18.08 doesn't have glib 2.60 (though this could be backported).

TingPing avatar Jun 15 '19 09:06 TingPing

Also add every KDE app to your list since the runtime pulls it in: https://github.com/KDE/flatpak-kde-runtime/blob/qt5.12lts/org.kde.Sdk.json#L55

TingPing avatar Jun 15 '19 09:06 TingPing

Also add every KDE app to your list since the runtime pulls it in: https://github.com/KDE/flatpak-kde-runtime/blob/qt5.12lts/org.kde.Sdk.json#L55

That's in the runtime, not in individual apps.

hadess avatar Jun 15 '19 09:06 hadess

That's in the runtime, not in individual apps.

AFAIK apps are inheriting those from runtime so it have to be changed in runtime however as KDE is based on fdo 18.08 which doesn't have newer glib it can't be done atm.

Erick555 avatar Jun 15 '19 11:06 Erick555

AFAIK apps are inheriting those from runtime so it have to be changed in runtime however as KDE is based on fdo 18.08 which doesn't have newer glib it can't be done atm.

Added KDE

hadess avatar Jun 16 '19 12:06 hadess

So the first pass of applications that its best to remove this from is probably GTK2 and Qt ones.

If the app:

  • Doesn't use DConf for its own settings storage
  • Doesn't support Wayland

It then means there is no regression removing it.

TingPing avatar Jun 16 '19 13:06 TingPing

com.stepmania.StepMania updated.

FakeShemp avatar Sep 17 '19 12:09 FakeShemp

You can mark KDE runtime as done. See https://github.com/KDE/flatpak-kde-runtime/commit/f41edbbb756418d9ea3cc5065e27073aeaeaadbb

grulja avatar Sep 18 '19 12:09 grulja

I'm sure I don't fully understand this DConf business, but how is io.github.liberodark.OpenDrive impacted by this? What is it what needs to be done to "fix" it? My knowledge is constrained to this guide.

x80486 avatar Dec 23 '19 00:12 x80486

ch.x29a.playitslowly is done (flathub/ch.x29a.playitslowly#2)

bochecha avatar Jan 08 '20 15:01 bochecha

These apps have already been updated.

https://github.com/flathub/io.github.Pithos [Archived] https://github.com/flathub/io.github.GnomeMpv https://github.com/flathub/org.audacityteam.Audacity https://github.com/flathub/org.mypaint.MyPaint https://github.com/flathub/org.gnome.Polari https://github.com/flathub/com.github.wwmm.pulseeffects https://github.com/flathub/org.gnome.Builder https://github.com/flathub/de.manuel_kehl.go-for-it https://github.com/flathub/org.gnome.Maps https://github.com/flathub/com.github.birros.WebArchives [Archived] https://github.com/flathub/cx.ring.Ring https://github.com/flathub/org.gnome.Gnote https://github.com/flathub/com.google.AndroidStudio https://github.com/flathub/io.github.jliljebl.Flowblade [Archived] https://github.com/flathub/com.github.bitseater.weather https://github.com/flathub/org.mozilla.Thunderbird https://github.com/flathub/io.github.janbar.noson https://github.com/flathub/com.github.muriloventuroso.easyssh https://github.com/flathub/com.axosoft.GitKraken https://github.com/flathub/org.synfig.SynfigStudio https://github.com/flathub/net.mancubus.SLADE https://github.com/flathub/com.github.bcedu.valasimplehttpserver [Archived] https://github.com/flathub/com.github.Cogitri.gxi https://github.com/flathub/com.github.naaando.lyrics https://github.com/flathub/mx.pwmc.Svgvi https://github.com/flathub/net.jami.Jami https://github.com/flathub/com.github.johnfactotum.Foliate https://github.com/flathub/net.lutris.Lutris

https://github.com/flathub/org.remmina.Remmina

dgcampea avatar Jan 09 '20 13:01 dgcampea

https://github.com/flathub/org.filezillaproject.Filezilla/pull/44

dgcampea avatar Jan 12 '20 13:01 dgcampea

https://github.com/flathub/org.libreoffice.LibreOffice/pull/110

dgcampea avatar Jan 14 '20 18:01 dgcampea

https://github.com/flathub/app.rednotebook.RedNotebook/pull/4

dgcampea avatar Jan 16 '20 12:01 dgcampea

com.slack.Slack should be updated

FakeShemp avatar Jun 19 '20 10:06 FakeShemp

org.gnome.Calendar and org.gnome.PasswordSafe were updated some time ago.

A6GibKm avatar Oct 09 '20 14:10 A6GibKm

com.github.PintaProject.Pinta should be updated

darkdragon-001 avatar Nov 26 '21 09:11 darkdragon-001

I've updated the checklist in the OP. These are the ones remaining, if anyone wants to help. I'll try to get to some of them in the coming weeks.

  • [x] https://github.com/flathub/com.github.IsmaelMartinez.teams_for_linux (PR opened)
  • [x] https://github.com/flathub/org.gabmus.unifydmin (Should be made EOL as per last chat with author)
  • [x] https://github.com/flathub/org.bluej.BlueJ
  • [x] https://github.com/flathub/com.wings3d.WINGS (PR opened)
  • [x] https://github.com/flathub/nl.g4d.Girens (PR opened)
  • [x] https://github.com/flathub/org.freac.freac (PR opened)
  • [x] https://github.com/flathub/com.notepadqq.Notepadqq (PR opened)
  • [x] https://github.com/flathub/org.gnome.Gtranslator
  • [x] https://github.com/flathub/org.laptop.TurtleArtActivity (PR opened)
  • [x] https://github.com/flathub/com.github.marktext.marktext (PR opened)
  • [x] https://github.com/flathub/com.lettier.movie-monad (Should be made EOL)
  • [x] https://github.com/flathub/org.gabmus.hydrapaper (PR opened)
  • [x] https://github.com/flathub/ca._0ldsk00l.Nestopia (PR opened)

https://github.com/flathub/org.gnome.Boxes (Blocked by https://github.com/flathub/org.gnome.Boxes/pull/54#issuecomment-715278589)

https://github.com/flathub/ca.desrt.dconf-editor (Seems necessary?)

bbhtt avatar Dec 13 '23 03:12 bbhtt

All are done here, the combination will be blocked by the linter shortly.

bbhtt avatar Jul 11 '24 04:07 bbhtt

The combination will be blocked by the linter shortly.

See https://github.com/flathub-infra/flatpak-builder-lint/pull/429

bbhtt avatar Jul 11 '24 05:07 bbhtt