go-guerrilla icon indicating copy to clipboard operation
go-guerrilla copied to clipboard

Published 20 hours ago • verified publisher icon flashmob

Add basic support for Proxy Protocol

Open danny-cheung opened this issue 7 years ago • 5 comments

danny-cheung avatar Oct 18 '18 03:10 danny-cheung

@flashmob Could you please

  • Re-run the latest that CI build. Some random flake crept into one of the jobs.
  • Review the PR

danny-cheung avatar Oct 18 '18 23:10 danny-cheung

@flashmob When would you have some time to look at this PR?

danny-cheung avatar Nov 19 '18 23:11 danny-cheung

Hi, thanks for your interest in contributing.

Is there an RFC or official spec that this PR is implementing?

flashmob avatar Jan 06 '19 06:01 flashmob

@flashmob https://www.haproxy.org/download/1.8/doc/proxy-protocol.txt

danny-cheung avatar Jan 06 '19 23:01 danny-cheung

This is only going to include PROXY v1, there's a v2. Might be worth using a library like https://github.com/pires/go-proxyproto instead to do the heavy lifting.

dekimsey avatar Aug 28 '19 16:08 dekimsey