Nikita Shilnikov

Results 182 comments of Nikita Shilnikov

Unfortunately, it's not enough to understand what went wrong. Can you provide a bull backtrace or a sample code that's failing? So that I can reproduce it on my side.

I think we can add a deprecation warning and cut a release. I would like to push 2.0 sometime soon anyway. `.then` is a common name for chaning promises/futures/etc but...

@koskoci yeah, all of them are rather ugly but we could slice ids into 1000-max lists and use multiple ORs. At the moment, I don't think there is anything except...

> But I wonder if it's intended to work this way too. The problem lies in implicit coercion with `to_hash`. `B` gets coerced to a hash and to an `A`...

Yeah, I do something similar to discriminate variants. 👍

I'm not sure I follow, dry-struct doesn't define `as_json`, why should it care? Serializing to JSON is not part of the gem and I'm against mixing concerns in general.

Thanks, I'll look into that. My gut feeling tells me such a change would break a lot of code.

I guess so, it's just about having a sanity check at the beginning of validation, no?

API-wise it's not a big deal, though I would expect `.JSON` and `.JSON(Hash)` to work the same way, just in case

I mean, no matter how we do this on the user side, dealing with arrays inside dry-schema will be non-trivial