keystore-idb icon indicating copy to clipboard operation
keystore-idb copied to clipboard

Default AES algorithm should be GCM

Open icidasset opened this issue 4 years ago • 5 comments

Replace current default algorithm AES-CTR with AES-GCM.

icidasset avatar Mar 29 '21 20:03 icidasset

We could fix this now that #58 landed

matheus23 avatar Nov 16 '21 12:11 matheus23

👍 And bump version to 1.0?

icidasset avatar Nov 16 '21 22:11 icidasset

I have some ideas for a "release" 1.0. E.g. I want the store to be abstracted, so that you can use keystore-idb (which at that point will be confusingly named) in nodejs.

Also, I think we can greatly reduce the API surface, because I don't think we're actually using the symmetric key store from keystore-idb anywhere. We're only using the AES helper methods (encryptBytes/decryptBytes).

Not a high priority right now though.

matheus23 avatar Nov 17 '21 10:11 matheus23

That'd be cool yeah. Where is that symmetric key store? But, it looks like we're using everything that's in aes/*.js.

icidasset avatar Nov 17 '21 19:11 icidasset

Ah, I'm actually wrong. I was talking about this: https://github.com/fission-suite/keystore-idb/blob/main/src/keystore/base.ts#L28

But we're actually using the keystore for symmetric keys: We're mainly using exportSymmKey and importSymmKey. My bad :)

Anyway, I still think a good abstraction over localforage in keystore-idb would be great. Probably best to copy the one from webnative into here, and use it from webnative.

If we have that, there's no reason for the dependency injection stuff we have in webnative (keystore-idb would work in nodejs with an appropriate localforage implementation).

matheus23 avatar Nov 18 '21 10:11 matheus23