ecs icon indicating copy to clipboard operation
ecs copied to clipboard

Nexus serialization

Open ctreffs opened this issue 4 years ago • 1 comments
trafficstars

Description

This PR aims to add serialization for the whole Nexus.

There are several challenges with this, but especially the static types on deserialization make it hard to get it right.

Open ToDos:

  • [ ] Encode to YAML, JSON, binary data
  • [ ] Decode from YAML, JSON, binary data

Detailed Design

For now arbitrary components are serialized into a binary format, but this should not be the final solution since this will produce a platform dependent and unstable serialization format.

Documentation

t.b.d.

Testing

t.b.d.

Performance

t.b.d.

Source Impact

t.b.d.

Checklist

  • [x] I've read the Contribution Guidelines
  • [x] I've followed the coding style of the rest of the project.
  • [x] I've added tests covering all new code paths my change adds to the project (to the extent possible).
  • [ ] I've added benchmarks covering new functionality (if appropriate).
  • [x] I've verified that my change does not break any existing tests or introduce unexpected benchmark regressions.
  • [ ] I've updated the documentation (if appropriate).

ctreffs avatar Nov 25 '20 10:11 ctreffs

Codecov Report

Merging #38 (df99994) into master (e1f3078) will decrease coverage by 3.78%. The diff coverage is 69.93%.

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
- Coverage   98.09%   94.31%   -3.79%     
==========================================
  Files          30       27       -3     
  Lines        1368     1214     -154     
==========================================
- Hits         1342     1145     -197     
- Misses         26       69      +43     

codecov[bot] avatar Nov 25 '20 10:11 codecov[bot]