firebase-js-sdk icon indicating copy to clipboard operation
firebase-js-sdk copied to clipboard
verified publisher icon firebase

login_hint should not be deleted from SAML AuthURIs

Open qodfathr opened this issue 5 years ago • 3 comments

[REQUIRED] Describe your environment

  • Operating System version: Windows 10
  • Browser version: Firefox 80.0.1 64-bit
  • Firebase SDK version: 4.5.2
  • Firebase Product: auth

[REQUIRED] login_hint not appended to SAML AuthURI

Steps to reproduce:

Using any SAML provider, supply a login_hint (such as [email protected]). Note that &[email protected] is not appended to the SAMLRequest URL

Relevant Code:

This test is wrong: https://github.com/firebase/firebase-js-sdk/blob/90b5f044b136211a39f891c05788bc46de1d2927/packages/auth/test/rpchandler_test.js#L7984 It is not a violation of the SAML standard to pass along custom parameters

This code is the root cause: https://github.com/firebase/firebase-js-sdk/blob/b73ab41356f5b86a693a0e6c5cdc1a6e9841b8e6/packages/auth/src/rpchandler.js#L1006

qodfathr avatar Oct 04 '20 17:10 qodfathr

Internally tracking via b/170137113

MeghaB avatar Oct 05 '20 19:10 MeghaB

Thanks for the inquiry, @qodfathr. We currently do not support custom parameters for SAML providers. We're filing this as a feature request.

bojeil-google avatar Nov 05 '20 17:11 bojeil-google

@bojeil-google this would be very useful, any updates on if this is posible?

milo-stadion avatar May 02 '24 21:05 milo-stadion