firebase-functions

firebase-functions copied to clipboard

Description

Calling logger.write() does not automatically add the traceId in logs like calling logger.log(), logger.error(), etc. Since the latter functions call logger.write() anyways, I moved the snippet of code setting the traceId to the write function.

Code sample

const { logger } = require("firebase-functions/v2/logger");

logger.write("TEST LOG", { severity: "NOTICE" });
// Prior to change, traceId was not set.

What is the reason behind this modification?

With console, you can only use debug, log, warning, and error. Logger uses much more fine tuned verbose levels. However, using those verbose levels does not attach the stack trace in Google Cloud Logging. This pull request adds the stack trace to all verbose levels.

It also makes it impossible to get trace information on critical+ log levels.