firebase-functions icon indicating copy to clipboard operation
firebase-functions copied to clipboard

Insert Expression and Field types into GlobalOptions and inheriting types

Open Berlioz opened this issue 3 years ago • 0 comments

By changing the types we allow inside the GlobalOptions parameter of the various CF3 setup functions, we automatically plumb them through to the ManifestSpec. Derived from #1168, which was busted enough I decided to just make a new branch.

So far, this PR still does not include:

~~the trigger type specific parameterized fields~~ full adjustments to the comments for the changed fields ~~any tests whatsoever~~ but it seems like we're going to rely more on integration tests here sanity checking on whether provided strings are actually CEL (but shouldn't we just validate that in the CLI?) but I wanted to see whether I was totally barking up the wrong tree first.

Berlioz avatar Jul 19 '22 08:07 Berlioz