refiners
refiners copied to clipboard
Add bias/use_bias to LinearLora/Conv2dLora for API convergence with Linear/Conv2d
Context
Still working on #165
Want to explore the lora/non-lora in the cross-attention adapter and to replace, conditionnaly
fl.Linear(
...
bias=text_cross_attention.use_bias
)
with
fl.LinearLora(
...
bias=text_cross_attention.use_bias
)
Remarks
- impacted also
Conv2DLorafor coherence - Default values are
False/Falsefor Lora andTrue/Truefor non-Lora layers, i feel it makes sense considering bias on LinearLora is not the rule - bias only impact the second lora layer, first lora layer bias are non-relevant on my POV