finch icon indicating copy to clipboard operation
finch copied to clipboard

Cats Effect 3 migration

Open kubukoz opened this issue 4 years ago β€’ 8 comments

Hi! Are there any plans in place to migrate to Cats Effect 3? If there are any blockers, it would be best to catch them before the RCs are being released. Asking for https://github.com/typelevel/cats-effect/issues/1330 :)

kubukoz avatar Feb 07 '21 17:02 kubukoz

Hello

Yes, however, this project needs some attention to update documentation first. I'll try to come back to it as soon as possible.

sergeykolbasov avatar Feb 08 '21 14:02 sergeykolbasov

Would a PR that executed this migration be welcomed?

stephen-lazaro avatar Nov 17 '21 18:11 stephen-lazaro

Proposal: https://github.com/finagle/finch/pull/1472

tpetillot avatar Apr 12 '22 11:04 tpetillot

a plan for RC1 was outlined here is this still the plan & what steps are still outstanding?

JackTreble avatar May 31 '22 11:05 JackTreble

Yes we need to decide on #1481 and #1478 - I think the former can be completed and merged, I'm not so sure about the latter.

joroKr21 avatar May 31 '22 13:05 joroKr21

Indeed, I don't think we should block the release candidate for a spec refactoring https://github.com/finagle/finch/pull/1478. I may complete https://github.com/finagle/finch/pull/1481 if needed, let me know! πŸ˜ƒ

tpetillot avatar May 31 '22 14:05 tpetillot

I may complete https://github.com/finagle/finch/pull/1481 if needed, let me know! πŸ˜ƒ

All yours, I think it's a good idea πŸ‘

joroKr21 avatar May 31 '22 16:05 joroKr21

As I don't know if you got notifications on the pull request, I let you know that https://github.com/finagle/finch/pull/1481 have been completed hereβœ”οΈ

tpetillot avatar Jun 10 '22 13:06 tpetillot

Hi folks, I would like to ask if there is a plan to release cats-effect 3 RC in the near future? Or alternatively, can you recommend using current implementation (available in the master branch) in the production code? This is not meant to rush anything, just seeking an advice, since we would like to update our project to cats-effect 3. Thanks in advance!

rosvit avatar Aug 22 '22 11:08 rosvit

@tpetillot I think we are ready to release but I don't remember what is the procedure. Is it enough to publish a tag? πŸ€”

joroKr21 avatar Sep 16 '22 12:09 joroKr21

@joroKr21 You can push a commit that removes the -SNAPSHOT from the version in version.sbt and CI will handle the rest. Something like this should work: https://github.com/finagle/finch/commit/9b18fb743fa62abc1fff74452133a9c93fb22567

rpless avatar Sep 16 '22 14:09 rpless

I released 0.34.0 with CE3 support. I didn't release 1.0 because I realised there are a lot of outstanding issues that might be potentially breaking binary compatibility. So I plan to go through them and check what is worth pursuing with fresh eyes.

joroKr21 avatar Sep 16 '22 17:09 joroKr21