Files icon indicating copy to clipboard operation
Files copied to clipboard

Fix: Fixed an issue with Nutstore cloud drive detection

Open wangfu91 opened this issue 1 year ago • 1 comments

Hi, I'm a developer at the company Nutstore, I've found out that the cloud drive detection logic for Nutstore in PR #10890 is incorrect.

Searching all the sub-directories named "Nutstore" in %userprofile% can be extremely time-consuming and will likely cause the Files app the stop responding, it may also result in multiple incorrect Nutstore cloud drive entries.

Querying the registry entries in SyncRootManager is a more efficient way to detect the root dir of the Nutstore cloud drive.

wangfu91 avatar May 22 '24 12:05 wangfu91

Fyi @hecksmosis

yaira2 avatar May 22 '24 14:05 yaira2

@wangfu91 thank you for the fix! While you're here, are there any other integrations that we can do with Nutestore to improve the experience (eg. context menu options etc)?

yaira2 avatar May 23 '24 14:05 yaira2

Thanks for merging my PR @yaira2, kudos for building such a beautiful app.

While you're here, are there any other integrations that we can do with Nutestore to improve the experience (eg. context menu options etc)?

Files have already properly integrated the context menu, I haven't found anything else to improve at the moment, I will raise an issue or create a PR if I do.

wangfu91 avatar May 24 '24 10:05 wangfu91