ShiftIt

ShiftIt copied to clipboard

Hey! This should fix #265

The release path was giving a 404. That being said, I know nothing about Sparkle, I just fixed the path. There may be steps left after that to make the auto updater work?

Thanks a lot! I wonder if we need the http://htmlpreview.github.com/? (nothing to do with this PR)...

I'm not 100% sure. A curl call to https://raw.github.com/fikovnik/ShiftIt/master/release/release-notes-1.6.5.html return a content-type of text/plain

while the same call to to http://htmlpreview.github.com/?https://raw.github.com/fikovnik/ShiftIt/master/release/release-notes-1.6.5.html return a content-type of text/html

So I guess that depends if Sparkle is blindly using the response, or if it's interpreting it based on the content-type. I would be inclined to think that it does the former, and you don't need the http://htmlpreview.github.com/? bit, but i'm not sure how to test it.

There is no easy way to test it, but publish the appcast somewhere with updated releaseNotesLink (for reproducibility the link will have to be some github project). Update the URL in Info.plist, recompile the app and test it out.

The reason why I was asking if the http://htmlpreview.github.com/? is needed is bacause ppl are having problems seeing the release notes.

Closing as I'm cleaning my open PRs and I'm pretty sure it's not actionable anymore.