Efficient-Compression-Tool icon indicating copy to clipboard operation
Efficient-Compression-Tool copied to clipboard

Published 20 hours ago • verified publisher icon fhanau

Zip recompression doesn't work when archive is not compressed

Open andrews05 opened this issue 7 years ago • 3 comments

For zip archives that have been created using level 0 ("store"), ect does not recompress the files inside.

andrews05 avatar Dec 03 '17 03:12 andrews05

Found this is deliberate by Leanify, though not sure why. For the record, advzip happily compresses these files.

andrews05 avatar Dec 03 '17 04:12 andrews05

https://github.com/fhanau/Efficient-Compression-Tool/blob/master/src/leanify/zip.cpp#L330 According to source code, this may break files. Even though I did not verify this claim, I don't think it's worth risking it.

fhanau avatar Dec 03 '17 08:12 fhanau

Ok, according to https://github.com/JayXon/Leanify/issues/42 this seems to be fine in most cases, so I will at least port these changes to add an option to compress uncompressed files within a zip file.

fhanau avatar Jun 09 '18 15:06 fhanau