Florent

Results 113 comments of Florent

We would need to clarify the User Story, prevent security issues and have a design mockup for this issue.

Thanks Alex! :pray: If we think ahead to the #416 issue, that endpoint would interest be a great key to its implementation: > `POST /docs/:docId/imports` with the request body below...

> Good question. I can see two possibilities: I like the second option, it sounds more RestFUL. Also to come back to your original post: > 1. `POST /docs/:docId/imports/upload` to...

@alexmojaki I think we agree on the implementation strategy, do you expect more feedback from other people?

@dsagal Does it mean that this issue can be assigned? (I can start working on it when I have the bandwidth)

I have just started working on it. I have some new questions: - `POST /docs/:docId/imports/upload` ⇒ it looks like the [upload mechanism](https://github.com/gristlabs/grist-core/blob/4a01c68a504cc96cde190aad4525d9e2f403ad4f/app/server/lib/uploads.ts#L123) (`handleUpload`) is just not need a `docId`, so...

It makes sense, thanks @dsagal!

After having taken a more thorough look at the code and at Alex's comment, I am torn between two options: - attempt to reuse the ActiveDocImport methods, which would mean...

In addition to what @vviers reports, I would also say that it can be painful to read the formulas too, to get the ACL overview (for example when debugging). Though...