simple-websocket icon indicating copy to clipboard operation
simple-websocket copied to clipboard

fix: migrate to streamx drop readable-stream

Open ThaUnknown opened this issue 3 years ago • 3 comments

https://github.com/webtorrent/webtorrent/issues/1971

the echo server no longer exists, and no services like it exist, so instead we create a server ourselves.

streamx uses "objectMode" by default as it doesn't force Buffer, so I re-implemented forced buffer mode, encoding doesn't exist on streamx, so I changed the test to objectMode as it's pretty much the same result.

ThaUnknown avatar Nov 03 '22 21:11 ThaUnknown

Socket Security Pull Request Report

👍 No new dependency issues detected in pull request

Pull request report summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Network access ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
GitHub dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
AI detected malware ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] [email protected]

Powered by socket.dev

socket-security[bot] avatar Nov 03 '22 21:11 socket-security[bot]

We should major version this change

I'm not certain this PR is correct fyi, as end might not fire on .destroy() with this? not 100% sure, asked mafintosh on feedback but he's ghosting too

ThaUnknown avatar Nov 10 '22 20:11 ThaUnknown

after testing, this is pretty much safe to merge, causes no issues anywhere

ThaUnknown avatar Nov 11 '22 19:11 ThaUnknown