fedimint
Add our license info to Cargo.toml's
looking at this, I'd say maybe homepage description readme would be also useful but not really important
How does this look? Should we add to each subcrate's toml or just the top level repo?
name = "fedimint" version = "0.0.0" authors = ["Fedimint Developers"] edition = "2021" rust-version = "1.56.0" description = "Fedimint is a prototype Federated Chaumian E-Cash Mint implementation, natively compatible with Bitcoin & the Lightning Network. This project is under heavy development, DO NOT USE WITH REAL FUNDS." documentation = "https://github.com/fedimint/fedimint/tree/master/docs" readme = "README.md" homepage = "https://fedimint.org" repository = "https://github.com/fedimint/fedimint" license = "MIT" license-file = "LICENSE" keywords = ["bitcoin", "lightning", "chaumian", "e-cash", "federated"]
Should we add to each subcrate's toml or just the top level repo?
Good question, from a short look at the Cargo Reference it seems like this would need to be added to every sub-crate.
rust-version = "1.56.0"
Dow we know our MSRV? If so we should test with it to not break it, if not we should not include it.
documentation = "https://github.com/fedimint/fedimint/tree/master/docs"
I think for now this is sufficient, but reminds me I have to fix docs.fedimint.org. EDIT: if we can wait for #462 this should be https://docs.fedimint.org instead imo (and we need better high level docs there).
I don't think we know our MSRV. IIRC I had problems on 1.62 but might have been my mistake.
How does this look? Should we add to each subcrate's toml or just the top level repo?
name = "fedimint" version = "0.0.0" authors = ["Fedimint Developers"] edition = "2021" rust-version = "1.56.0" description = "Fedimint is a prototype Federated Chaumian E-Cash Mint implementation, natively compatible with Bitcoin & the Lightning Network. This project is under heavy development, DO NOT USE WITH REAL FUNDS." documentation = "https://github.com/fedimint/fedimint/tree/master/docs" readme = "README.md" homepage = "https://fedimint.org" repository = "https://github.com/fedimint/fedimint" license = "MIT" license-file = "LICENSE" keywords = ["bitcoin", "lightning", "chaumian", "e-cash", "federated"]
We are on edition = "2018" IIRC editions are breaking changes so we can`t just bump it without further investigation.
Also what does MSRV mean @elsirion ? minimum stable rust version ? (if so would this mean with what min version it compiles or with what min version its bug free (how do you ever know your project is bug free anyway..))
I think the edition jump is ok. We forbid warnings in CI and single edition jumps only make warnings to errors afaik, so if you didn't have warnings before you are good. MSRV=minimum supported rust version.