documentation icon indicating copy to clipboard operation
documentation copied to clipboard

Published 20 hours ago • verified publisher icon feature-sliced

Added project PseudoTube

Open MaksimPir opened this issue 2 years ago • 6 comments

Background

Added my own project PseudoTube, it is an example of project where using FSD

Changelog

Added in /pages/examples/img/pseudoTube_screens.png Added in /pages/examples/config

MaksimPir avatar Nov 01 '23 13:11 MaksimPir

Deploy request for pr-fsd rejected.

Name Link
Latest commit 88260936bb9cc447d8728fe2a8655f89197bb6d3

netlify[bot] avatar Nov 01 '23 13:11 netlify[bot]

Hey, thanks for the example! Didn't review the code yet, will do soon, but I have some preliminary comments in the meantime:

  1. Could you delete the .vs folder from your PR please?
  2. I see in your GitHub that you have a link to the preview, could you also add that?

illright avatar Nov 04 '23 08:11 illright

Hi! Added commit, please check it.

MaksimPir avatar Nov 04 '23 13:11 MaksimPir

I checked out the code and the architectural part feels pretty solid, but I'm really not a fan of the website design, namely, the colors. Could you change that?

illright avatar Nov 11 '23 22:11 illright

Hm... I think colors and design are subjective for everyone. In my opinion, this case suggests an example for learning how to use FSD in practice, and not about a beautiful web interface. The colors I chose for my application are not so ugly and do not hurt the eyes of users. If you can tell me the colors I should use, then I will change them

MaksimPir avatar Nov 12 '23 10:11 MaksimPir

Consider the visual style of well-established component libraries such as MUI, Ant Design, Carbon, etc. They often have a white background with high-contrast text and sparse use of accent colors.

illright avatar Nov 13 '23 16:11 illright

Closing this as stale

illright avatar Feb 25 '24 21:02 illright