feathersui-openfl icon indicating copy to clipboard operation
feathersui-openfl copied to clipboard

Published 20 hours ago • verified publisher icon feathersui

Added code that makes LayoutViewPort offscreen rendering optional

Open barisyild opened this issue 3 years ago • 4 comments

In my testing, huge scroll containers get huge performance gains!

barisyild avatar May 18 '22 09:05 barisyild

This feature should be integrated into openfl.

barisyild avatar May 18 '22 17:05 barisyild

Per our discussion, BaseScrollContainer has a scrollMode property that can use scrollRect, mask, and no masking. Even if OpenFL optimized its scrollRect implementation, this feature would still be useful for the other scroll modes.

joshtynjala avatar May 18 '22 18:05 joshtynjala

Looks good to me. I might make a few very minor code style tweaks after merging, but otherwise, everything is good. Added to v1.1 milestone.

joshtynjala avatar May 19 '22 20:05 joshtynjala

Oh wait, not good yet. Flash builds are still failing because you are referencing __children, which is an OpenFL private API. Please use items instead. That's defined in LayoutGroup, so it will be safe everywhere.

joshtynjala avatar May 19 '22 20:05 joshtynjala