feathers
feathers copied to clipboard
fix: default custom-env-config settings caused name conflicts
Summary
HOSTNAME is available in most Posix systems by default, so it can override your config/default.json OOTB. This is not a well known fact and a new feature in Dove. This conditions combined cause unexpected bindings, errors and interactions with other parts of your server/app/system.
Suggested solution
Namespace them.
Additional details
This reminds me of another feathers-configuration feature, relating to path resolution, that caused unexpected issues. I chose not to include OAUTH secrets as the origin definition seems imperfect, as it somewhat duplicates the top level origins.
https://github.com/feathersjs/feathers-chat/blob/dove/feathers-chat-ts/config/custom-environment-variables.json