feathers icon indicating copy to clipboard operation
feathers copied to clipboard

Published 20 hours ago • verified publisher icon feathersjs

Add instructions for handling CORS for sockets

Open blackmann opened this issue 3 years ago • 2 comments

Summary

Since v3 of socket.io cors options need to be explicit. https://socket.io/docs/v3/handling-cors/

I spent about two hours figuring out what's happening; I think it'll be helpful to others in future if the docs stated how to handle it.

  • [x] Tell us about the problem your pull request is solving.
  • [ ] Are there any open issues that are related to this?
  • [ ] Is this PR dependent on PRs in other repos?

blackmann avatar Jul 24 '22 20:07 blackmann

Deploy Preview for feathers-dove failed.

Name Link
Latest commit 223e9384b537d89928d90751d56e101dbced1638
Latest deploy log https://app.netlify.com/sites/feathers-dove/deploys/62dda5350c2168000ae6856b

netlify[bot] avatar Jul 24 '22 20:07 netlify[bot]

Hm... this is a good point, I'm wondering if the CLI should do more here and ask for the origin urls.

daffl avatar Aug 03 '22 15:08 daffl