onesignal icon indicating copy to clipboard operation
onesignal copied to clipboard

It doesn't reject on error

Open jdegger opened this issue 8 years ago • 3 comments

I hate the following result:

{
	errors: ['Identifier invalid format.']
}

This does not seem to reject the Promise but silently fails with an undefined value in the callback (since .id is undefined).

This is on the addDevice function

jdegger avatar Apr 09 '17 15:04 jdegger

Same here

kanji-keraliya avatar Aug 16 '18 11:08 kanji-keraliya

@jdegger @kanji-keraliya

Can you please provide a sample code and more explanation for the issue ?

faressoft avatar Aug 16 '18 11:08 faressoft

screenshot_2

kanji-keraliya avatar Aug 16 '18 11:08 kanji-keraliya