fantasy-io icon indicating copy to clipboard operation
fantasy-io copied to clipboard

Published 20 hours ago • verified publisher icon fantasyland

Compliance to latest spec (Issue #2)

Open nadameu opened this issue 8 years ago • 5 comments

nadameu avatar Aug 17 '17 19:08 nadameu

I think we should also set the fantasy-land dependency to "3.3.x" or "3.x.x".

davidchambers avatar Aug 17 '17 21:08 davidchambers

and add fantasy-land/ prefixes

safareli avatar Aug 18 '17 16:08 safareli

and add fantasy-land/ prefixes

I believe we're doing this already by using [ap] rather than .ap.

davidchambers avatar Aug 18 '17 17:08 davidchambers

@davidchambers oh yes, didn't noticed.

safareli avatar Aug 19 '17 17:08 safareli

This PR breaks tests for applicative interface:

io.js
✖ io - All (Applicative)

TypeError: f is not a function
    at (anonymous function) (D:\Wojciech\JS\fantasy-io\src\io.js:18:38)
    at Ctor.IO [as unsafePerform] (D:\Wojciech\JS\fantasy-io\src\io.js:13:21)
    at Ctor.IO [as unsafePerform] (D:\Wojciech\JS\fantasy-io\src\io.js:13:45)
    at run (D:\Wojciech\JS\fantasy-io\test\io.js:17:14)
    at D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\laws\applicative.js:16:25
    at D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\laws\applicative.js:77:33
    at rec (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-seqs\src\seq.js:34:38)
    at Ctor.Cons (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-seqs\src\seq.js:39:20)
    at Ctor.cata (D:\Wojciech\JS\fantasy-io\node_modules\daggy\daggy.js:134:40)
    at Ctor.Seq.fold (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-seqs\src\seq.js:37:17)
    at Ctor.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\laws\applicative.js:76:41)
    at Ctor.forAll (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\check.js:99:23)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\adapters\nodeunit.js:58:28)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16

✖ io - Identity (Applicative)

TypeError: f is not a function
    at (anonymous function) (D:\Wojciech\JS\fantasy-io\src\io.js:18:38)
    at Ctor.IO [as unsafePerform] (D:\Wojciech\JS\fantasy-io\src\io.js:13:21)
    at Ctor.IO [as unsafePerform] (D:\Wojciech\JS\fantasy-io\src\io.js:13:45)
    at run (D:\Wojciech\JS\fantasy-io\test\io.js:17:14)
    at Ctor.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\laws\applicative.js:16:25)
    at Ctor.forAll (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\check.js:99:23)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\adapters\nodeunit.js:58:28)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16
    at Object.exports.runTest (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:70:9)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:118:25
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:513:13
    at iterate (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:123:13)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:134:25
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:515:17

✖ io - Composition (Applicative)

TypeError: f is not a function
    at (anonymous function) (D:\Wojciech\JS\fantasy-io\src\io.js:18:38)
    at Ctor.IO [as unsafePerform] (D:\Wojciech\JS\fantasy-io\src\io.js:13:21)
    at Ctor.IO [as unsafePerform] (D:\Wojciech\JS\fantasy-io\src\io.js:13:45)
    at run (D:\Wojciech\JS\fantasy-io\test\io.js:17:14)
    at Ctor.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\laws\applicative.js:24:25)
    at Ctor.forAll (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\check.js:99:23)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\adapters\nodeunit.js:58:28)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16
    at Object.exports.runTest (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:70:9)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:118:25
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:513:13
    at iterate (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:123:13)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:134:25
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:515:17

✖ io - Homomorphism (Applicative)

TypeError: f is not a function
    at (anonymous function) (D:\Wojciech\JS\fantasy-io\src\io.js:18:38)
    at Ctor.IO [as unsafePerform] (D:\Wojciech\JS\fantasy-io\src\io.js:13:21)
    at Ctor.IO [as unsafePerform] (D:\Wojciech\JS\fantasy-io\src\io.js:13:45)
    at run (D:\Wojciech\JS\fantasy-io\test\io.js:17:14)
    at Ctor.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\laws\applicative.js:32:25)
    at Ctor.forAll (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\check.js:99:23)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\adapters\nodeunit.js:58:28)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16
    at Object.exports.runTest (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:70:9)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:118:25
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:513:13
    at iterate (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:123:13)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:134:25
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:515:17

✖ io - Interchange (Applicative)

TypeError: f is not a function
    at (anonymous function) (D:\Wojciech\JS\fantasy-io\src\io.js:18:38)
    at Ctor.IO [as unsafePerform] (D:\Wojciech\JS\fantasy-io\src\io.js:13:21)
    at Ctor.IO [as unsafePerform] (D:\Wojciech\JS\fantasy-io\src\io.js:13:45)
    at run (D:\Wojciech\JS\fantasy-io\test\io.js:17:14)
    at Ctor.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\laws\applicative.js:40:25)
    at Ctor.forAll (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\check.js:99:23)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\adapters\nodeunit.js:58:28)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16
    at Object.exports.runTest (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:70:9)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:118:25
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:513:13
    at iterate (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:123:13)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:134:25
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:515:17

wojpawlik avatar Apr 26 '18 19:04 wojpawlik